fix crash and broken jump mode in criticals module#6380
Open
xvrrv wants to merge 1 commit intoMeteorDevelopment:masterfrom
Open
fix crash and broken jump mode in criticals module#6380xvrrv wants to merge 1 commit intoMeteorDevelopment:masterfrom
xvrrv wants to merge 1 commit intoMeteorDevelopment:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
fixes a
ClassCastExceptioncrash when using minijump or jump mode in criticalsthe issue: ServerboundInteractPacket was declared here
but incoming packet was
ServerboundAttackPacketso when casting here detects wrong class and crash
the fix is just change class to
ServerboundAttackPacketand cast itand jump mode wasnt actually jumping because wrong method was used here
actual method is
Related issues
#6379
How Has This Been Tested?
singleplayer and multiplayer, every mode works fine
Checklist: